feat(ci): add the deploy-preview workflow PLATFORM.md already documents - #31
Merged
Conversation
PLATFORM.md states that a PR touching platform/ gets a scorecard comment from deploy-preview.yml. The file did not exist, so deployment changes here merged with no readiness gate at all -- the only service repository in that position. It was not addable before: knowledge-ingest-worker declares no health path, which the SC-11 health_declared check treated as a failure, so adding the workflow would have turned every platform/ PR red. With the worker now explicitly exempt the scorecard passes, and the gate reports something true. Configuration matches the other six repositories and the values already used by publish.yml: deploy-dir platform, schema-version 0.20.0, the same digest-pinned context ref, environments production.
ExtraToast
added
the
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLATFORM.mdstates:That file did not exist. Deployment changes in this repository have been merging with no readiness gate at all — the only one of the seven service repos in that position, and the reason its
health_declaredgap went unnoticed until the shared checker was run here by hand.Why it could not be added before
knowledge-ingest-workerdeclares no health path, and the SC-11health_declaredcheck treated that as a failure. Adding the workflow would have turned everyplatform/PR red on a condition a queue consumer cannot satisfy. With the worker now explicitly exempt (#30), the scorecard passes and the gate reports something true.Configuration
Matches the other six repositories, and the values
publish.ymlalready uses:deploy-dir: platform,schema-version: 0.20.0, the same digest-pinned context ref,environments: production, pinned atgithub-workflowsv0.16.0 — the release where a pin actually selects the action code that runs.platform/images.lock.jsonexists at the referenced path.Verification
./platform/render-local.shhere renders five fragments and passes every check, with the exemption named in the detail column, so the firstplatform/PR after this lands will get a green scorecard rather than an immediate red one.